Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update DataDog instructions #3319

Merged
merged 8 commits into from
Dec 17, 2024
Merged

docs: Update DataDog instructions #3319

merged 8 commits into from
Dec 17, 2024

Conversation

ahdriel
Copy link
Member

@ahdriel ahdriel commented Nov 19, 2024

Features and Changes

  • Updated DataDog integration docs

Copy link

github-actions bot commented Nov 19, 2024

Deploy preview for docs ready!

✅ Preview
https://docs-gx3j6fq05-growthbook.vercel.app

Built with commit b8b3362.
This pull request is being automatically deployed with vercel-action

@ahdriel ahdriel requested a review from royalfig December 13, 2024 00:17
@ahdriel ahdriel marked this pull request as ready for review December 14, 2024 00:03

datadogRum.addFeatureFlagEvaluation("welcome-message", welcomeMessage);
```
trackingCallback: (experiment, result) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine, but we also have a onFeatureUsage cb, which seems perfect for this use case. See https://docs.growthbook.io/lib/react#feature-usage-callback

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh TIL -- do you know if we have the same for all other SDKs or is this a JS only thing?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure TBH. Looking at the docs, it doesn't seem so, but I'd ask @madhuchavva because they'll likely have a better sense.

docs/docs/integrations/datadog.mdx Outdated Show resolved Hide resolved
@ahdriel ahdriel merged commit 190f239 into main Dec 17, 2024
6 checks passed
@ahdriel ahdriel deleted the av/update-datadog-docs branch December 17, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants