Fix useFeaturesList changing object pointers every rerender #3141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kevin-Chant
commented
Oct 18, 2024
Comment on lines
+213
to
+218
| if (data) { | ||
| setFeatures(data.features); | ||
| setExperiments(data.linkedExperiments); | ||
| setHasArchived(data.hasArchived); | ||
| } | ||
| }, [data]); |
There was a problem hiding this comment.
I don't think I need to have an else to reset the fields back to [] if the data changes back to empty, but could be wrong
|
Your preview environment pr-3141-bttf has been deployed. Preview environment endpoints are available at: |
bryce-fitzsimons
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features and Changes
On Firefox there's been a general error "the operation is insecure" on the main
/featurespage for a few weeks now.The reason for this is we have a
useMemoinservices/search.tsxwhich does a shallow replace on the router's query params whenever an object changes. That object in turn is auseMemobased on the items being searched over, and those items (in the case of/features) are theFeatureInterface[]returned byuseFeaturesList.The problem is that each time the hook is called (due to re-rendering for other reasons) the default empty array that's returned is a new object, so this was causing us to change the query params hundreds of times, which Firefox blocked as a security issue.
Testing
Using Firefox, load http://localhost:3000/features on
mainand on this branch and observe the difference.Optionally, add a console log to the
if (updateSearchQueryOnChange)clause inservices/search.tsxto see the frequency at which we callrouter.replaceScreenshots
Before
After