New webhook modal design. #2756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your preview environment pr-2756-bttf has been deployed. Preview environment endpoints are available at: |
mknowlton89
reviewed
Jul 18, 2024
Comment on lines
-134
to
-137
| case "ms-teams": | ||
| // TODO: not implemented | ||
| return eventPayload; | ||
|
|
There was a problem hiding this comment.
@romain-growthbook Can you share the details of the ms-teams integration - were we planning to eventually build it out, but now we'll just support it via the raw type?
There was a problem hiding this comment.
There is none at the moment. I think that I added this to be fancy back when. We could probably add one similar to slack and discord if they provide the same webhook workflow..
mknowlton89
approved these changes
Jul 18, 2024
Great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the new UI/UX for webhook create/edit modal as outlined at: https://www.figma.com/design/lJ5VnBNTwIP4VGgeBEU2bM/Experiment-Notifications?node-id=60-9869&t=AxMWenhwBLswO95Y-0
The only part that is left is the new modal to test the webhood before saving.
Screenshots
Raw webhook
Payload type selection
Discord webhook
Select all behavior
The checkbox is disabled when no selection has been made:
It becomes enabled again when a selection is made:
Upon checking the box, all selections are discarded and we are back at the first screenshot.