Allow uppercase letters in feature keys #2491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docs ready! ✅ Preview Built with commit e5ca7bc. |
|
Your preview environment pr-2491-bttf has been deployed. Preview environment endpoints are available at: |
This was
linked to
issues
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features and Changes
Previously, if someone entered
MyFeatureas the key when creating a new feature, it would silently lowercase it before saving, so the result would bemyfeature. Not only was this unexpected behavior, it also meant users couldn't use camel case for features. In some languages, camel case is standard so this forced users to go against the language naming best practices.This PR removes this restriction and allows uppercase letters to remain as part of feature keys.
With the recent change in #2479 , organizations can add their own regex to enforce a stricter naming convention if desired.