Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split out general settings #2462

Merged
merged 1 commit into from
May 2, 2024

Conversation

romain-growthbook
Copy link
Contributor

@romain-growthbook romain-growthbook commented May 1, 2024

This is a factorization I did as part of the experiment notification work that I'd like to apply before it starts conflicting!

@romain-growthbook romain-growthbook force-pushed the romain/split-out-general-settings branch from cabcbb9 to 82e82fe Compare May 1, 2024 14:54
@romain-growthbook romain-growthbook changed the title Romain/split out general settings Split out general settings May 1, 2024
@romain-growthbook romain-growthbook force-pushed the romain/split-out-general-settings branch from 82e82fe to 2771824 Compare May 1, 2024 14:55
@romain-growthbook romain-growthbook requested review from jdorn and bttf May 1, 2024 14:58
@romain-growthbook romain-growthbook force-pushed the romain/split-out-general-settings branch from 2771824 to 6d13026 Compare May 1, 2024 14:58
Copy link

github-actions bot commented May 1, 2024

Your preview environment pr-2462-bttf has been deployed.

Preview environment endpoints are available at:

@romain-growthbook romain-growthbook merged commit e53bba6 into main May 2, 2024
3 checks passed
@romain-growthbook romain-growthbook deleted the romain/split-out-general-settings branch May 2, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants