Bugfix: JS SDK - Wait for document.body to load #2002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bttf
changed the title
|
Your preview environment pr-2002-bttf has been deployed. Preview environment endpoints are available at: |
|
Deploy preview for docs ready! ✅ Preview Built with commit c760e89. |
bttf
force-pushed
the
adnan/sdk-js-custom-js-fix-01
branch
from
7213719 to
a2522db
Compare
jdorn
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features and Changes
In some cases the JS SDK will try to apply changes to
document.bodybefore it has loaded.This leads to a broken state for the SDK and blocks experiments from running.
This PR modifies the way we mount a customers custom JS by appending the containing
<script>tag todocument.headinstead.Also adding docs to remind users that their custom JS will run immediately on page load and to take steps to assert the body or descendant elements exist before executing against them.
document.bodyis loaded #1982Error state
Dependencies
Testing
Tested locally
https://www.loom.com/share/61700daefe224a5391986e387cdb663f
Old:
https://www.loom.com/share/a64ed476288a44608c80d5dbb2236b2a