Cancel link now actually cancels queries in BigQuery/Athena #1847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, the "cancel" queries link would stop waiting for results and update the GrowthBook UI, but the queries would still be executing in the database in the background. Now, for BigQuery and Athena, we will send a cancel request to the database as well. Unfortunately, not all db engines support easily cancelling an in-progress query, which is why we're starting with only two.
|
Your preview environment pr-1847-bttf has been deployed. Preview environment endpoints are available at: |
jdorn
changed the title
lukesonnet
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
Looks good to me. Tested on BQ and it:
- Canceled my dedupe units table query that was expensive
- Updated the mongo correctly with that error
- BQ job correctly shows it was canceled by the user in the BQ UI
- Unfortunately, it left the dependent queries in "queued" status (see my comments)
So at first glance it seems sufficient and to work, but might be good to clean up a little bit after itself.
| ); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Can we also set queued and running queries to "failed"? Otherwise we have to wait for the cleanup job that I think only handles 20 queries at a time right now.
| return async () => { | ||
| if (!id || !this.integration.cancelQuery) return; | ||
| try { | ||
| await this.integration.cancelQuery(id); |
There was a problem hiding this comment.
It feels like we should also run onQueryFinish() in here, which might clean up the queued queries automatically anyways (see my below comment)
itsgrimetime
pushed a commit
to itsgrimetime/growthbook
that referenced
this pull request
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features and Changes
Before, the "cancel" queries link would stop waiting for results and update the GrowthBook UI, but the queries would still be executing in the database in the background.
Now, for BigQuery and Athena, we will send a cancel request to the database as well.
Unfortunately, not all db engines support easily cancelling an in-progress query, which is why we're starting with only two.