Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce id prop for SingleRoleSelector #1072

Merged
merged 3 commits into from
Mar 14, 2023
Merged

Conversation

tinahollygb
Copy link
Contributor

Features and Changes

Fixes a bug with using multiple SingleRoleSelector components.

Dependencies

n/a

Testing

  • Go to invite a team member: http://localhost:3000/settings/team
  • Choose multiple project roles.
  • For each of these roles, choose engineer (or another with more privileges)
  • Toggle "Restrict Access to Specific Environments" for each of these.

Screenshots

role selector bug

Copy link
Member

@bryce-fitzsimons bryce-fitzsimons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions
Copy link

Your preview environment pr-1072-bttf has been deployed.

Preview environment endpoints are available at:

Copy link
Member

@bryce-fitzsimons bryce-fitzsimons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I might make id an optional prop on SingleRoleSelector, but autogeneration is fine too.

@tinahollygb
Copy link
Contributor Author

lgtm. I might make id an optional prop on SingleRoleSelector, but autogeneration is fine too.

Thanks @bryce-fitzsimons – yeah we went back and forth on the id prop here but I think the preference is auto-generation for ease of implementation.

@tinahollygb tinahollygb merged commit 88b2587 into main Mar 14, 2023
@tinahollygb tinahollygb deleted the bug/role-selector-toggle branch March 14, 2023 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants