Support Redis in cluster mode #21
Conversation
| @@ -170,43 +183,58 @@ export class RedisCache { | |||
|
|
|||
| // Redis requires that subscribers use a separate client | |||
| this.subscriberClient = this.client.duplicate(); | |||
There was a problem hiding this comment.
This seems that it is only necessary for the Redis client, not the Redis cluster.
https://github.com/redis/node-redis/blob/master/docs/pub-sub.md
There was a problem hiding this comment.
I've switched the GB Proxy over to ioredis since node-redis has some issues with flakiness and incomplete TS bindings (specifically for cluster mode). Ioredis recommends using a separate client for subscribing even in cluster mode. While the general Redis docs indicate that you don't technically need to separate your subscribe client from normal usage due to how the Cluster message bus works, it's still a recommended practice to separate them (scalability, separation of concerns, flexibility) and there's no real downside to doing so.
Of course this is just my own research and I have not battle-tested this at scale. If you have scalability insights here, would be great to learn of them.
Supports Redis in cluster mode via 2 new environment variables:
USE_CLUSTER- "true" or "1" to enableCLUSTER_ROOT_NODES- comma-separated URLs to your cluster seed nodes