Expose SPIRType::ImageType to Rust #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors bot
added a commit
that referenced
this pull request
Apr 6, 2021
170: Expose SPIRType::ImageType to Rust r=grovesNL a=Rob2309 These changes allow querying the type of an Image/SampledImage resource more effectively. Now you can query - The dimension of the Image (1D, 2D, Cube, etc.) - The format of the Image, if known - How it is accessed (Sampled or read directly) - whether it is an array texture - ... Co-authored-by: Robin Quint <[email protected]>
|
Timed out. |
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Apr 6, 2021
170: Expose SPIRType::ImageType to Rust r=grovesNL a=Rob2309 These changes allow querying the type of an Image/SampledImage resource more effectively. Now you can query - The dimension of the Image (1D, 2D, Cube, etc.) - The format of the Image, if known - How it is accessed (Sampled or read directly) - whether it is an array texture - ... Co-authored-by: Robin Quint <[email protected]>
|
Timed out. |
|
Oh I forgot to mention, I also exposed the array_size_literal information for the types it applies to. "storage" and "width" fields are also present in the wrapper but not yet exposed to rust, since I had no need for them yet. |
|
Sounds good 👍 thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes allow querying the type of an Image/SampledImage resource more effectively. Now you can query