-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to cosmic-text #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch from
fontdue
tocosmic-text
.cosmic-text
provides more functionality thanfontdue
(check thecosmic-text
readme to compare againstfontdue
if you're curious) and the performance should be relatively comparable for typical use cases.cosmic-text
appears to be slightly slower when I tested with a text-heavy application, but this is mostly due to the shaping inrustybuzz
(which has room for future performance optimization) and can usually be cached.Because of the functionality I've decided to switch over to
cosmic-text
, but please feel free to fork an earlier version ofglyphon
if you'd like to continue using it withfontdue
. For now it doesn't feel worthwhile trying to maintain both implementations in the same repository, though I'd be open to some kind of solution to this if there's a lot of interest.