Add WebGL Extensions #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grovesNL
approved these changes
Oct 15, 2019
bors bot
added a commit
that referenced
this pull request
Oct 15, 2019
51: Add WebGL Extensions r=grovesNL a=TannerRogalsky This enables and tracks all supported WebGL extensions. It also uses those extensions to add vertex array objects and instanced drawing to WebGL1 when supported. Some areas of potential interest: - stdweb's VAO extension implementation returns a different type than the non-extension implementation. I've resolved this by tracking the extension resource separately but with the same key type. - WebGL extensions are all `[NoInterfaceObject]`s and aren't represented as JS classes and therefore can't be cast into Rust classes in the normal way (using `JsCast::dyn_into`). Instead `unchecked_into` is used along with the web_sys-provided Rust classes to duck-type these extensions. As I understand it, [this is the expected way](rustwasm/wasm-bindgen#1449). - I've employed a macro to cut down on code duplication around the web_sys extension creation because their WebGL1 and WebGL2 context share an API but not a useful trait. I'm of course open to any suggestions on how to improve this. Co-authored-by: Tanner Rogalsky <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables and tracks all supported WebGL extensions. It also uses those extensions to add vertex array objects and instanced drawing to WebGL1 when supported.
Some areas of potential interest:
[NoInterfaceObject]s and aren't represented as JS classes and therefore can't be cast into Rust classes in the normal way (usingJsCast::dyn_into). Insteadunchecked_intois used along with the web_sys-provided Rust classes to duck-type these extensions. As I understand it, this is the expected way.I'm of course open to any suggestions on how to improve this.