Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accra integration tests using unittests #85

Merged
merged 9 commits into from
Nov 29, 2017
Merged

Conversation

prhod
Copy link
Collaborator

@prhod prhod commented Oct 31, 2017

This PR aim to check Accra generated Data's consistency with osm2gtfs evolutions.
The same tests framework as #78 is used.
Those tests will ease validations of modifications using Overpass Mocks and an expected GTFS result generated with the provided mocks.
There are some code duplications, but avoiding them would conflicts with in progress PR ;-)

Copy link
Collaborator

@nlehuby nlehuby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very good start for #75 👍

Copy link
Owner

@grote grote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, the one minor issue can be fixed later.


1. Generation of the cache stops Data from an Overpass result Mock
* Generation of the cache routes Data from an Overpass result Mock
* Generation of the GTFS ZIP File using the previously generated cache data
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The enumeration does seem to be broken here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for that, my markdown editor was ok with this syntaxe

@grote grote merged commit 17729f9 into grote:master Nov 29, 2017
@pantierra
Copy link
Contributor

Very nice!

@grote
Copy link
Owner

grote commented Nov 29, 2017

@prhod how about adding these to the CI?

@prhod prhod deleted the tests_accra branch November 30, 2017 17:41
@prhod
Copy link
Collaborator Author

prhod commented Nov 30, 2017

Thanks for the merge. I'll create an other PR with the fix of the readme and the addition of the tests in the CI. I'm glad you suggested it, I was'nt confident that it was a good idea ;)

@grote
Copy link
Owner

grote commented Nov 30, 2017

I'm glad you suggested it, I was'nt confident that it was a good idea ;)

No, I think it is a good idea. If a new PR breaks Accra, we want to know right away without doing manual tests.

You can create another test stage for unit tests.

@pantierra
Copy link
Contributor

Yes, please add to the CI, this gives immediate feedback. Thanks!

@prhod
Copy link
Collaborator Author

prhod commented Dec 1, 2017

Readme fix and CI integration available in #93 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants