-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accra integration tests using unittests #85
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very good start for #75 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, the one minor issue can be fixed later.
|
||
1. Generation of the cache stops Data from an Overpass result Mock | ||
* Generation of the cache routes Data from an Overpass result Mock | ||
* Generation of the GTFS ZIP File using the previously generated cache data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The enumeration does seem to be broken here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for that, my markdown editor was ok with this syntaxe
Very nice! |
@prhod how about adding these to the CI? |
Thanks for the merge. I'll create an other PR with the fix of the readme and the addition of the tests in the CI. I'm glad you suggested it, I was'nt confident that it was a good idea ;) |
No, I think it is a good idea. If a new PR breaks Accra, we want to know right away without doing manual tests. You can create another test stage for unit tests. |
Yes, please add to the CI, this gives immediate feedback. Thanks! |
Readme fix and CI integration available in #93 :) |
This PR aim to check Accra generated Data's consistency with osm2gtfs evolutions.
The same tests framework as #78 is used.
Those tests will ease validations of modifications using Overpass Mocks and an expected GTFS result generated with the provided mocks.
There are some code duplications, but avoiding them would conflicts with in progress PR ;-)