-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for required via tag (if given inside OSM data) #129
Conversation
I was first hesitating about the |
I've only rebased and made pep8 happy 😆 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ialokim for all these bug fixes! :)
osm2gtfs/creators/trips_creator.py
Outdated
if (trip[ | ||
"from"] == itinerary.fr and trip[ | ||
"to"] == itinerary.to and service in trip_services): | ||
"to"] == itinerary.to and trip[ | ||
"via"] == itinerary.via and service in trip_services): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was already like this, but breaking open the accessor like this looks like bad style. Can we keep trip["via"]
together without line breaks?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've changed it accordingly, it's now like in line 87.
Before merging this, we should check all the creators' GTFSes, because of the new required information in the schedule file. I had to fix Esteli's |
Thanks @ialokim! |
This PR adds support for the required
via
tag if it is set in the OSM data.After merging in #126, this PR should be rebased and we should change the verification check introduced there by adding the
via
tag.Fixes #101.