Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename of setter causes invalid rename to bean-style access #1013

Closed
eric-milles opened this issue Dec 30, 2019 · 1 comment
Closed

Rename of setter causes invalid rename to bean-style access #1013

eric-milles opened this issue Dec 30, 2019 · 1 comment
Assignees
Labels
Milestone

Comments

@eric-milles
Copy link
Member

eric-milles commented Dec 30, 2019

Consider the following:

class C {
  String foo
  void setFoo(String value) {
    this.foo = value
  }
}
@groovy.transform.CompileStatic
class D {
  void meth(C c) {
    c.foo = ''
  }
}

Renaming "setFoo" to "setX" incorrectly renames bean-style reference "c.foo" to "c.setX". Removing the @CompileStatic and renaming properly changes the expression to "c.x = ''".

@eric-milles
Copy link
Member Author

eric-milles commented Dec 30, 2019

org.codehaus.groovy.classgen.asm.sc.StaticPropertyAccessHelper.PoppingMethodCallExpression uses "setFoo" as method name. Cause by change in cbdc80d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant