Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create REST based dummy build server #186

Merged
merged 8 commits into from
Aug 12, 2020
Merged

Create REST based dummy build server #186

merged 8 commits into from
Aug 12, 2020

Conversation

BerndNK
Copy link
Member

@BerndNK BerndNK commented Aug 5, 2020 •
edited
Loading

Rewrites the previously pipe-based dummy build server with a REST-based server.

@BerndNK BerndNK linked an issue Aug 5, 2020 that may be closed by this pull request
Rewrite DummyBuildServer #170
Closed
@BerndNK BerndNK added this to the 0.4.0 milestone Aug 5, 2020
@BerndNK BerndNK requested a review from TheSylence August 5, 2020 12:15
TheSylence
TheSylence reviewed Aug 5, 2020
View reviewed changes
Copy link
Member

@TheSylence TheSylence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really cool 😎

Since this is the DummyBuildServer I wouldn't say any of my comments must be resolved. I just noted those things.

DummyServer/ClientApp/package.json Show resolved Hide resolved
DummyServer/ClientApp/src/app/home/home.component.html Show resolved Hide resolved
DummyServer/ClientApp/src/app/home/home.component.ts Show resolved Hide resolved
DummyServer/ClientApp/src/app/home/home.component.ts Outdated Show resolved Hide resolved
DummyServer/Controllers/BuildController.cs Outdated Show resolved Hide resolved
DummyServer/Controllers/BuildController.cs Outdated Show resolved Hide resolved
DummyServer/Controllers/BranchController.cs Outdated Show resolved Hide resolved
DummyServer/Controllers/BuildController.cs Outdated Show resolved Hide resolved
DummyServer/Controllers/BuildController.cs Outdated Show resolved Hide resolved
@BerndNK BerndNK merged commit ae268d9 into master Aug 12, 2020
@BerndNK BerndNK deleted the dummyWithRest branch August 12, 2020 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheSylence TheSylence TheSylence left review comments

Assignees
No one assigned
Labels
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.

Rewrite DummyBuildServer
2 participants
@BerndNK @TheSylence