Skip to content

Commit

Permalink
Remove container names for podman
Browse files Browse the repository at this point in the history
The way we currently setup podman containers in the Makefile, we don't
get any kind of namespacing for containers. To avoid clashes with
other names, we avoid giving the containers names at all. Most user
operations are can still refer to the stable name of the pod.
  • Loading branch information
Kritzefitz committed May 27, 2022
1 parent 07790e7 commit 5f26f94
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@ COMPOSER_VERSION = 2.1.5
COMPOSER_CHECKSUM = be95557cc36eeb82da0f4340a469bad56b57f742d2891892dcb2f8b0179790ec
IMAGE_TAG ?= $(shell git describe --tags --match 'v*' --dirty)
IMAGE_PREFIX ?= docker.io/grocy
BACKEND_CONTAINER_NAME ?= grocy-backend
FRONTEND_CONTAINER_NAME ?= grocy-frontend
POD_NAME ?= grocy-pod
APP_DB_VOLUME_NAME ?= grocy-app-db
PUBLISH_AT ?= 127.0.0.1:8080
Expand All @@ -21,7 +19,6 @@ create: pod
--add-host frontend:127.0.0.1 \
--add-host backend:127.0.0.1 \
--env-file grocy.env \
--name "${BACKEND_CONTAINER_NAME}" \
--pod "${POD_NAME}" \
--read-only \
--volume /var/log/php8 \
Expand All @@ -31,7 +28,6 @@ create: pod
--add-host grocy:127.0.0.1 \
--add-host frontend:127.0.0.1 \
--add-host backend:127.0.0.1 \
--name "${FRONTEND_CONTAINER_NAME}" \
--pod "${POD_NAME}" \
--read-only \
--tmpfs /tmp \
Expand Down

0 comments on commit 5f26f94

Please sign in to comment.