Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loop while reading from standalone evtx #1

Merged
merged 1 commit into from
Jan 25, 2022
Merged

Conversation

grishinpv
Copy link
Owner

What does this PR do?

Tjis fix adds checking EOF to prevent constant loop while reading standalone evtx file

Why is it important?

When we reach the end of the file (case io.EOF) we set stop = true.
But next we continue the loop regardless stop value and read whole file again and again.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

When we reach the end of the file (case io.EOF) we set stop = true.
But next we continue look regardless stop value and read whole file again and again
@grishinpv grishinpv added the bug Something isn't working label Jan 25, 2022
@grishinpv grishinpv merged commit a49281f into master Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant