Added Swift Package Manager support #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Swift Package Manager by adding a Package.swift file (I have tested this integration on my local branch where it integrates into a sample project without issue).
It also adds support for Carthage, I had thought that previous PR (#28) would be enough to enable Carthage compatibility by simply marking the scheme as shared however as it turned out when I attempted to integrate LNZCollectionLayouts using Carthage there were a few more requirements.
In the end I had to add a header and an Info.plist for the framework as well (the existing Info.plist used by the sample application was renamed to AppInfo.plist with Info.plist used for the framework target and AppInfo.plist used the sample app) and resolved a couple of small compilation issues.
I currently integrate LNZCollectionLayouts via Carthage using my fork but hope that with this PR merged it should be possible to switch to using the official (this) repository.