-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update ONIOM and TAtomList #851
Conversation
Signed-off-by: albert <[email protected]>
Signed-off-by: albert <[email protected]>
Signed-off-by: albert <[email protected]>
Signed-off-by: albert <[email protected]>
Why do we need zeros in the atom list, this sounds like some out of bounds issue to me. |
So, the problem right now is that zeros in Atomlist will throw segfault. Alternatively, we could raise an error. |
I think we should rather add checks to avoid adding zeros in the first place to the list. |
Signed-off-by: albert <[email protected]>
I assume that performing a direct check is not possible since the TAtomList parser is explicitly composed of pure procedures. I've altered the error handling approach: now, whenever it encounters a non-integer value or zero, it throws an error. If you have any more insightful suggestions for enhancing this, I'd be glad to hear them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me then
* handle 0 in atom list Signed-off-by: albert <[email protected]> * cleanup oniom.f90 Signed-off-by: albert <[email protected]> * update xcontrol docs for new oniom settings Signed-off-by: albert <[email protected]> * small interatomic distances warning Signed-off-by: albert <[email protected]> * handle 0 and any non-integer value as an error Signed-off-by: albert <[email protected]> --------- Signed-off-by: albert <[email protected]> Signed-off-by: Johannes Gorges <[email protected]>
add warning if the distances between added link atom (H) and any other atom is too short (smaller than H2) ->
check_dist
update man page
allow for 0 in TAtomList (e.g.
1,2,0,12
)