Add torsion potential to GFN-FF for rotation around triple bonded carbon #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Albkat
reviewed
Mar 23, 2023
src/gfnff/gfnff_ini.f90
Outdated
Comment on lines
1870
to
1872
| else | ||
| ! allocate with size() = 0 | ||
| allocate(topo%sTorsl(6, nn), source=0) |
There was a problem hiding this comment.
Do you really need this?
you can just remove this and then check in gfnf_eg, if the topo%sTorsl allocated
There was a problem hiding this comment.
I changed it below, thanks.
Account for the calc time of the new torsional term
Albkat
approved these changes
Mar 23, 2023
Lower the distance for carbon triple bond
Do not allocate topo%sTorsl if no torsion around triple bonded carbon was found.
Only apply special torsion potential if topo%sTorsl is allocated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This potential was requested to get the correct torsion potentials for diphenylacetylene.