Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of a generic docking algorithm #677

Merged
merged 3 commits into from
Oct 10, 2022
Merged

Conversation

cplett
Copy link
Member

@cplett cplett commented Aug 3, 2022

-the docking submodule was implemented
-it can add two molecules based on an interaction site screening with the xtbIFF energy
-geometry optimizations with a GFN method follow automatically
-it is executed with "xtb dock [options]"
-the resulting energetically lowest structure is on file best.xyz, the best 15 structures on file final_structures.xyz
-the documentation will follow later

awvwgk
awvwgk previously requested changes Aug 4, 2022
Copy link
Member

@awvwgk awvwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use implicit none and make all exports explicit. Also end each unit (subroutine, module, function) with the name of the respective unit.

src/docking/meson.build Outdated Show resolved Hide resolved
src/iff/calculator.f90 Outdated Show resolved Hide resolved
Comment on lines 56 to 60
use xtb_docking_param
use xtb_type_environment, only : TEnvironment
use xtb_type_molecule, only : TMolecule
use xtb_iff_iffini, only : init_iff!, precomp
use xtb_iff_data, only : TIFFData
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Import only in module scope, use public and private to limit reexports


type(TEnvironment), intent(inout) :: env

type(TMolecule), intent(in) :: comb!Combined structure of molA and molB (molA has to be first)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
type(TMolecule), intent(in) :: comb!Combined structure of molA and molB (molA has to be first)
!> Combined structure of molA and molB (molA has to be first)
type(TMolecule), intent(in) :: comb

Comment on lines 81 to 91
fnam='xtblmoinfA'
call rd0(1,trim(fnam),calc%dat%n1,calc%dat%nlmo1)
call rd(trim(fnam),1,calc%dat%n1,calc%dat%xyz1,calc%dat%at1&
&,calc%dat%nlmo1,calc%dat%lmo1,calc%dat%rlmo1,calc%dat%q1,&
& calc%dat%qct1)

fnam='xtblmoinfB'
call rd0(2,trim(fnam),calc%dat%n2,calc%dat%nlmo2)
call rd(trim(fnam),2,calc%dat%n2,calc%dat%xyz2,calc%dat%at2,&
& calc%dat%nlmo2,calc%dat%lmo2,calc%dat%rlmo2,calc%dat%q2,&
& calc%dat%qct2)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end if


end subroutine
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always include the name of the subroutine in the end statement


end subroutine

end module
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add module name

use xtb_mctc_accuracy, only: wp
use xtb_docking_param
use xtb_iff_ifflmo

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use implicit none and explicit exports

use xtb_splitparam
use xtb_iff_calculator, only: TIFFCalculator
implicit none

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

explicit exports

Comment on lines +1584 to +1588
case('--nat')
call args%nextArg(sec)
if (allocated(sec)) then
call set_natom(env,sec)
end if
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this command for?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is required for setting the number of atoms of the first molecule in the input structure of a xtb-IFF single point calculation.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why a fixed range (1-n)? We have much more flexible input models for fragments available.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good point. I will change this.

@awvwgk awvwgk dismissed their stale review September 5, 2022 12:06

Requested changes addressed

@awvwgk awvwgk added this to the v6.6.0 milestone Sep 5, 2022
@cplett cplett force-pushed the dock branch 2 times, most recently from 4114b5c to 2995824 Compare October 7, 2022 07:59
@cplett cplett merged commit ee5b291 into grimme-lab:main Oct 10, 2022
@cplett cplett deleted the dock branch December 12, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants