Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parallelization strategy for numerical differention #465

Merged
merged 1 commit into from
Apr 19, 2021

Conversation

awvwgk
Copy link
Member

@awvwgk awvwgk commented Apr 17, 2021

  • Intel Fortran has problems to properly handle orphaned OpenMP

@ucb-mgcf, @sespic, @fabothch Do you mind rechecking your failing examples with the version uploaded at:
https://github.com/awvwgk/xtb/suites/2519893098/artifacts/54567679

Closes #458

- Intel Fortran has problems to properly handle orphaned OMP
@awvwgk awvwgk added this to the v6.4.1 milestone Apr 17, 2021
@fabothch
Copy link
Member

The system I investigated works now, when using GFN-FF. From my side this appears to work.

@awvwgk awvwgk merged commit 7f6c899 into grimme-lab:master Apr 19, 2021
@awvwgk awvwgk deleted the omp-hess branch April 19, 2021 12:08
@ucb-mgcf
Copy link

The above link to the version for me to test appears to be broken. Should I test this by installing the latest master branch?

@awvwgk
Copy link
Member Author

awvwgk commented Apr 20, 2021

GitHub invalidates the uploaded artifacts from workflows quite quickly, the patch is included in the version on the bleed tag as well now:
https://github.com/grimme-lab/xtb/releases/tag/bleed

@ucb-mgcf
Copy link

I just confirmed that this calculation now works using the original specification, i.e. OMP_NUM_THREADS=16,1 with the bleeding-edge version. Thanks! For efficiency, would you now recommend continuing to use OMP_NUM_THREADS=1,n or go back to using OMP_NUM_THREADS=n,1?

@awvwgk
Copy link
Member Author

awvwgk commented Apr 20, 2021

n,1 distribution should work best, the more easy to exploit parallelism is in the displacements of the hessian instead of the individual SCC calculations. You can try to set OMP_SCHEDULE=dynamic as well, in some cases it can improve the load balancing on the threads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hess calculation seg fault
3 participants