Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate logic for MKL linking from static option #241

Merged
merged 1 commit into from
Jun 2, 2020

Conversation

awvwgk
Copy link
Member

@awvwgk awvwgk commented Jun 1, 2020

Deletes the -Dstatic option, separates mkl, mkl-static (default) and mkl-rt as linear algebra backends.

la_backend Description
mkl link shared MKL libraries, produce dynamically linked binaries
mkl-static link static MKL libraries, produce statically linked binaries
mkl-rt link real time MKL library, produce dynamically linked binaries

Precompiled binaries will be provided with Intel 17 and mkl-static.

mkl-static is included for convenience and because it is the default for distribution of xtb.
Following setup is equivalent to mkl-static:

meson setup build -Dla_backend=mkl -Dfortran_link_args=-static

To link static binaries with other backends the -Dfortran_link_args=-static flag should be provided in the configuration step.

Fixes #237

@awvwgk awvwgk added the build Build system related issues (OS, compilers, meson) label Jun 1, 2020
@awvwgk awvwgk mentioned this pull request Jun 1, 2020
@pierre-24
Copy link

... -Dla_backend=mkl works for me <3

@awvwgk awvwgk merged commit e106a6d into grimme-lab:master Jun 2, 2020
@awvwgk awvwgk deleted the mkl-linking branch June 2, 2020 08:30
@pierre-24
Copy link

pierre-24 commented Jun 2, 2020

(didn't you forget to upgrade the documentation, or is it going in the RTD one ?)

@awvwgk
Copy link
Member Author

awvwgk commented Jun 2, 2020

The static flag was a hidden feature for you so far. But the in detail description of all the possibilities to link the MKL will go to RTD rather than the meson guide here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build system related issues (OS, compilers, meson)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot build project tests
2 participants