Fix unknown option error in meson >= 0.60.0 #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awvwgk
reviewed
Jan 19, 2022
Codecov Report
@@ Coverage Diff @@
## master #66 +/- ##
=======================================
Coverage 97.04% 97.04%
=======================================
Files 8 8
Lines 440 440
=======================================
Hits 427 427
Misses 13 13 Continue to review full report at Codecov.
|
|
Thanks for sharing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Attempting to install xtb-python using meson versions past 0.60.0 produces the following error:
subprojects/xtb/meson.build:19:0: ERROR: In subproject xtb: Unknown options: "xtb:static"Commenting out line 47 in the primary meson.build file suppresses this error.
I have not looked through the repository in-depth to confirm that this setting is not used, but this error coincides with a change to meson to always produce a fatal error when an unknown setting is encountered. xTB-python appears to install and run correctly with this setting disabled.
Changelog description
Fixed unknown option error in meson versions >= 0.60.0