Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logs on voltage limits #46

Merged
merged 57 commits into from
Apr 10, 2024
Merged

Add logs on voltage limits #46

merged 57 commits into from
Apr 10, 2024

Conversation

Tristan-WorkGH
Copy link
Contributor

@Tristan-WorkGH Tristan-WorkGH commented Mar 22, 2024 •
edited
Loading

  • Add logs
    • logs tree in serialized JSON in resources like in others analysis servers
    • central shared root reporter in analysis context
    • also move existing log line where it's calculated to have all logs in one place
  • Add missing lombok config, which fix wrong coverage
  • Fix resource loading problems with classpath in tests

@Tristan-WorkGH Tristan-WorkGH self-assigned this Mar 22, 2024
@ne0ds ne0ds self-requested a review March 26, 2024 09:14
ne0ds
ne0ds reviewed Mar 26, 2024
View reviewed changes
pom.xml Outdated
<groupId>junit</groupId>
<artifactId>junit</artifactId>
<scope>test</scope>
</dependency>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated change

This comment was marked as outdated.

Sign in to view

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to #51

ne0ds
ne0ds reviewed Mar 26, 2024
View reviewed changes
.mvn/lombok-config-copy.marker Outdated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of this file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The project was missing .mvn/lombok-config-copy.marker & lombok.config, with consequence of very bad coverage with Sonar for example.

ne0ds
ne0ds reviewed Mar 26, 2024
View reviewed changes
lombok.config Outdated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of this file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use common lombok config as base

etiennehomer
etiennehomer requested changes Mar 26, 2024
View reviewed changes
pom.xml Outdated
<groupId>junit</groupId>
<artifactId>junit</artifactId>
<scope>test</scope>
</dependency>

This comment was marked as outdated.

Sign in to view

src/main/java/org/gridsuite/voltageinit/server/service/VoltageInitRunContext.java Outdated Show resolved Hide resolved
...n/java/org/gridsuite/voltageinit/server/service/parameters/VoltageInitParametersService.java Show resolved Hide resolved
...n/java/org/gridsuite/voltageinit/server/service/parameters/VoltageInitParametersService.java Show resolved Hide resolved
...n/java/org/gridsuite/voltageinit/server/service/parameters/VoltageInitParametersService.java Outdated Show resolved Hide resolved
src/test/java/org/gridsuite/voltageinit/service/ReportServiceTest.java Outdated Show resolved Hide resolved
src/test/java/org/gridsuite/voltageinit/utils/TestUtils.java Show resolved Hide resolved
src/test/java/org/gridsuite/voltageinit/utils/assertions/ReflectiveRepresentation.java Outdated Show resolved Hide resolved
...n/java/org/gridsuite/voltageinit/server/service/parameters/VoltageInitParametersService.java Outdated Show resolved Hide resolved
...n/java/org/gridsuite/voltageinit/server/service/parameters/VoltageInitParametersService.java Outdated Show resolved Hide resolved
@Tristan-WorkGH
review
438e199 
replace `@TestFactory` by individual `@Test`
@Tristan-WorkGH
fix tests
68cf7b5 
problem of SpringBoot contexts when mixing JUnit4 & JUnit5
@Tristan-WorkGH
review
e0ec908 
clean PR
antoinebhs
antoinebhs requested changes Apr 8, 2024
View reviewed changes
src/main/java/org/gridsuite/voltageinit/server/service/VoltageInitWorkerService.java Outdated Show resolved Hide resolved
src/main/java/org/gridsuite/voltageinit/server/service/VoltageInitRunContext.java Outdated Show resolved Hide resolved
...n/java/org/gridsuite/voltageinit/server/service/parameters/VoltageInitParametersService.java Outdated Show resolved Hide resolved
...n/java/org/gridsuite/voltageinit/server/service/parameters/VoltageInitParametersService.java Outdated Show resolved Hide resolved
...n/java/org/gridsuite/voltageinit/server/service/parameters/VoltageInitParametersService.java Outdated Show resolved Hide resolved
...n/java/org/gridsuite/voltageinit/server/service/parameters/VoltageInitParametersService.java Outdated Show resolved Hide resolved
...n/java/org/gridsuite/voltageinit/server/service/parameters/VoltageInitParametersService.java Outdated Show resolved Hide resolved
...n/java/org/gridsuite/voltageinit/server/service/parameters/VoltageInitParametersService.java Outdated
//The optimizer will attach reactive slack variables to all buses
parameters.setReactiveSlackBusesMode(ReactiveSlackBusesMode.ALL);

long nanoTime = System.nanoTime();
LOGGER.info("Parameters built in {}s", TimeUnit.NANOSECONDS.toSeconds(System.nanoTime() - startTime.getAndSet(nanoTime)));
LOGGER.info("Parameters built in {}s", TimeUnit.NANOSECONDS.toSeconds(System.nanoTime() - startTime));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessary for this PR, to revert

...n/java/org/gridsuite/voltageinit/server/service/parameters/VoltageInitParametersService.java Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
96.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

antoinebhs
antoinebhs approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@antoinebhs antoinebhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code OK
Test OK

@Tristan-WorkGH Tristan-WorkGH merged commit 17f00d4 into main Apr 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoinebhs antoinebhs antoinebhs approved these changes

@etiennehomer etiennehomer etiennehomer approved these changes

@ne0ds ne0ds Awaiting requested review from ne0ds

Assignees

@Tristan-WorkGH Tristan-WorkGH

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Tristan-WorkGH @antoinebhs @etiennehomer @ne0ds