Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate security analysis endpoints to add rootNetworkUuid in path #650

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Migrate security analysis endpoints to add rootNetworkUuid in path #650

wants to merge 8 commits into from

Conversation

klesaulnier
Copy link
Contributor

No description provided.

LE SAULNIER Kevin added 3 commits December 12, 2024 13:49
feat: migrate run security-analysis endpoint to path with root network
f68726e 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
(cherry picked from commit ac4bdf4)
feat: migrate get security-analysis results endpoint to path with roo…
0202180 
…t network

Signed-off-by: LE SAULNIER Kevin <[email protected]>
(cherry picked from commit 6b066fd)
feat: migrate all security-analysis endpoint to root network ones
f5b26ad 
Signed-off-by: LE SAULNIER Kevin <[email protected]>
@klesaulnier klesaulnier changed the title Security analysis endpoint migrated to root-nerworks usage Migrate security analysis endpoints to add rootNetworkUuid in path Dec 12, 2024
@SlimaneAmar SlimaneAmar self-requested a review January 8, 2025 11:55
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 8, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

SlimaneAmar
SlimaneAmar reviewed Jan 8, 2025
View reviewed changes
src/test/java/org/gridsuite/study/server/utils/StudyTestUtils.java
@@ -0,0 +1,21 @@
package org.gridsuite.study.server.utils;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we not use TestUtils ?

@SlimaneAmar
Copy link
Contributor

Throw an exception for this method is ok

public UUID getNetworkUuid(UUID rootNetworkUuid) {
        return getRootNetwork(rootNetworkUuid).map(RootNetworkEntity::getNetworkUuid).orElseThrow(() -> new StudyException(NETWORK_NOT_FOUND));
    }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SlimaneAmar SlimaneAmar SlimaneAmar left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@klesaulnier @SlimaneAmar