-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use notifications to manage parameter changes #614
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
53f4b67
setip params notification.
AAJELLAL da714fb
Some cleanup.
AAJELLAL 6a3a5f5
Merge branch 'main' of https://github.com/gridsuite/study-server into…
AAJELLAL 2811124
Merge branch 'main' of https://github.com/gridsuite/study-server into…
AAJELLAL dc03b0a
Add parameter name to the notification header and fix tests.
AAJELLAL 8e334f0
Send params notification after updating the provider.
AAJELLAL 0fc79bb
Merge branch 'main' of https://github.com/gridsuite/study-server into…
AAJELLAL 9ca36c3
Fix tests.
AAJELLAL 911ceb3
Change some names + fix the review remarks.
AAJELLAL 64cde18
Merge branch 'main' of https://github.com/gridsuite/study-server into…
AAJELLAL 93c9c1e
fix checkstyle.
AAJELLAL a510096
review remarks.
AAJELLAL 400ef5a
Merge branch 'main' of https://github.com/powsybl/powsybl-study-serve…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -72,6 +72,7 @@ | |
import static org.gridsuite.study.server.StudyConstants.HEADER_RECEIVER; | ||
import static org.gridsuite.study.server.StudyConstants.HEADER_USER_ID; | ||
import static org.gridsuite.study.server.notification.NotificationService.HEADER_UPDATE_TYPE; | ||
import static org.gridsuite.study.server.notification.NotificationService.UPDATE_TYPE_COMPUTATION_PARAMETERS; | ||
import static org.junit.Assert.*; | ||
import static org.mockito.ArgumentMatchers.any; | ||
import static org.mockito.Mockito.doAnswer; | ||
|
@@ -658,6 +659,8 @@ public void testNonEvacuatedEnergyParameters() throws Exception { | |
.contentType(MediaType.APPLICATION_JSON) | ||
.content(myBodyJson)).andExpect( | ||
status().isOk()); | ||
Message<byte[]> message = output.receive(TIMEOUT, studyUpdateDestination); | ||
assertEquals(UPDATE_TYPE_COMPUTATION_PARAMETERS, message.getHeaders().get(NotificationService.HEADER_UPDATE_TYPE)); | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same, you don't test HEADER_COMPUTATION_TYPE here and elsewhere |
||
mockMvc.perform(get("/v1/studies/{studyUuid}/non-evacuated-energy/parameters", studyNameUserIdUuid)).andExpectAll( | ||
status().isOk(), | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could assert that it's certainly LOADFLOW in HEADER_COMPUTATION_TYPE here as well