Update Limit Reductions Table Form to display duration bounds in minutes and adjust translations accordingly #2451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tes and adjust translations accordingly Signed-off-by: jamal-khey <[email protected]>
SlimaneAmar
reviewed
Dec 17, 2024
| if (lowBound === 0) { | ||
| return intl.formatMessage({ id: 'LimitDurationAfterIST' }, { value: highBound }); | ||
| } | ||
| const lowBoundLabel = lowBound === 0 ? 'IST' : 'IT ' + lowBound; |
There was a problem hiding this comment.
?
IST it's for permanent limit
src/components/dialogs/parameters/common/limitreductions/limit-reductions-table-form.tsx
Show resolved
Hide resolved
Signed-off-by: jamal-khey <[email protected]>
Signed-off-by: jamal-khey <[email protected]>
SlimaneAmar
reviewed
Dec 18, 2024
src/components/dialogs/parameters/common/limitreductions/limit-reductions-table-form.tsx
Outdated
Show resolved
Hide resolved
src/components/dialogs/parameters/common/limitreductions/limit-reductions-table-form.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: jamal-khey <[email protected]>
Signed-off-by: jamal-khey <[email protected]>
Signed-off-by: jamal-khey <[email protected]>
Signed-off-by: jamal-khey <[email protected]>
Signed-off-by: jamal-khey <[email protected]>
Signed-off-by: jamal-khey <[email protected]>
Signed-off-by: jamal-khey <[email protected]>
Signed-off-by: jamal-khey <[email protected]>
jamal-khey
commented
Dec 30, 2024
src/components/dialogs/parameters/common/limitreductions/limit-reductions-table-form.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: jamal-khey <[email protected]>
…o jamal-khey/redesing-limit-reductions
SlimaneAmar
approved these changes
Dec 31, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.