Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add substation creation to voltagelevel creation form #2439

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

add substation creation to voltagelevel creation form #2439

wants to merge 5 commits into from

Conversation

ghazwarhili
Copy link
Contributor

No description provided.

@basseche basseche self-requested a review December 16, 2024 10:06
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
5.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

basseche
basseche requested changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@basseche basseche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed with PO you have to make some changes to :

  • add a separator line or better to isolate the substation creation
  • correct editing of substation creation (see all fields).
  • add "add property" button to add properties to substation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basseche basseche basseche requested changes

@EtienneLt EtienneLt Awaiting requested review from EtienneLt

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghazwarhili @basseche