Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite the service layer in typescript. #2387

Merged
merged 40 commits into from
Dec 26, 2024
Merged

Rewrite the service layer in typescript. #2387

merged 40 commits into from
Dec 26, 2024

Conversation

AAJELLAL
Copy link
Contributor

No description provided.

AAJELLAL added 17 commits October 31, 2024 14:08
@AAJELLAL
Transformer loadflow service to TS.
59823d4 
Signed-off-by: AAJELLAL <[email protected]>
@AAJELLAL
Transformer geo-data service to TS.
1a86b8b 
Signed-off-by: AAJELLAL <[email protected]>
@AAJELLAL
Transformer non-evacuated-energy service to TS.
7a8e17c 
Signed-off-by: AAJELLAL <[email protected]>
@AAJELLAL
Transformer SA service to TS.
c7eac6d 
Signed-off-by: AAJELLAL <[email protected]>
@AAJELLAL
Merge branch 'main' of https://github.com/gridsuite/gridstudy-app int…
d399e1e 
…o main
@AAJELLAL
Transformer Sensi service to TS.
a20e0b8 
Signed-off-by: AAJELLAL <[email protected]>
@AAJELLAL
Transformer shortCircuit, voltage init,Sensi, SA and notification ser…
624a773 
…vices to TS.

Signed-off-by: AAJELLAL <[email protected]>
@AAJELLAL
Merge branch 'main' of https://github.com/gridsuite/gridstudy-app int…
be89a8a 
…o main
@AAJELLAL
Transformer tree, config, study notification and user admin services …
c62b5ba 
…to TS.

Signed-off-by: AAJELLAL <[email protected]>
@AAJELLAL
Merge branch 'main' of https://github.com/gridsuite/gridstudy-app int…
8482eb5 
…o main
@AAJELLAL
Transformer study index services to TS.
ed91015 
Signed-off-by: AAJELLAL <[email protected]>
@AAJELLAL
Transform network service to TS.
9b75637 
Signed-off-by: AAJELLAL <[email protected]>
@AAJELLAL
Merge branch 'main' of https://github.com/gridsuite/gridstudy-app int…
43a7a96 
…o main

# Conflicts:
#	src/services/study/network.ts
@AAJELLAL
Resolve conflict.
17cfbe0 
Signed-off-by: AAJELLAL <[email protected]>
@AAJELLAL
convert the rest of the service files to ts.
c966529 
Signed-off-by: AAJELLAL <[email protected]>
@AAJELLAL
Merge branch 'main' of https://github.com/gridsuite/gridstudy-app int…
6134d4e 
…o main
@AAJELLAL
Fix some errors.
5af1f3a 
Signed-off-by: AAJELLAL <[email protected]>
souissimai
souissimai reviewed Nov 14, 2024
View reviewed changes
src/services/network-modification-types.ts Outdated Show resolved Hide resolved
src/services/study/index.ts Outdated Show resolved Hide resolved
src/services/study/index.ts Outdated Show resolved Hide resolved
jamal-khey
jamal-khey reviewed Nov 14, 2024
View reviewed changes
src/components/network/network-map-tab.tsx Outdated Show resolved Hide resolved
src/services/directory.ts Show resolved Hide resolved
src/services/network-modification-types.ts Outdated Show resolved Hide resolved
src/services/network-modification-types.ts Outdated Show resolved Hide resolved
src/services/network-modification-types.ts Outdated Show resolved Hide resolved
src/services/network-modification-types.ts Outdated Show resolved Hide resolved
src/services/study/geo-data.ts Outdated Show resolved Hide resolved
@AAJELLAL
Merge branch 'main' of https://github.com/gridsuite/gridstudy-app int…
6efbf2a 
…o ali/rewrite-service-in-typescript

# Conflicts:
#	src/services/study/network-modifications.ts
#	src/services/study/network.ts
jamal-khey
jamal-khey reviewed Dec 3, 2024
View reviewed changes
src/services/study/network-modifications.ts Show resolved Hide resolved
src/services/study/network-modifications.ts Show resolved Hide resolved
src/services/study/network-modifications.ts Show resolved Hide resolved
src/services/study/network-modifications.ts Show resolved Hide resolved
src/services/study/network-modifications.ts Outdated Show resolved Hide resolved
src/services/study/security-analysis.ts Outdated Show resolved Hide resolved
src/services/study/sensitivity-analysis.ts Show resolved Hide resolved
src/services/study/sensitivity-analysis.ts Outdated Show resolved Hide resolved
src/services/study/short-circuit-analysis.ts Show resolved Hide resolved
...ponents/dialogs/network-modifications/delete-attaching-line/delete-attaching-line-dialog.jsx Show resolved Hide resolved
Tristan-WorkGH
Tristan-WorkGH reviewed Dec 5, 2024
View reviewed changes
src/components/network-modification-tree-pane.jsx Show resolved Hide resolved
src/components/study-container.jsx Show resolved Hide resolved
src/redux/user-store.ts Show resolved Hide resolved
src/services/network-modification-types.ts Outdated Show resolved Hide resolved
src/services/network-modification-types.ts Outdated Show resolved Hide resolved
src/services/network-modification-types.ts Show resolved Hide resolved
src/services/study/loadflow.ts Show resolved Hide resolved
@AAJELLAL
Merge branch 'ali/rewrite-service-in-typescript' of https://github.co…
e13129f 
…m/gridsuite/gridstudy-app into ali/rewrite-service-in-typescript
@AAJELLAL
Merge branch 'main' of https://github.com/gridsuite/gridstudy-app int…
fd08f0a 
…o ali/rewrite-service-in-typescript

# Conflicts:
#	src/services/study/tree-subtree.ts
@AAJELLAL
Add some types.
0e6ac72 
Signed-off-by: AAJELLAL <[email protected]>
@AAJELLAL
Fix sonar issues.
75d6434 
Signed-off-by: AAJELLAL <[email protected]>
@AAJELLAL
Remove the todos to fix sonar issues and remove unused code.
643462d 
Signed-off-by: AAJELLAL <[email protected]>
@AAJELLAL
Fix some review remarks
da50fe8 
Signed-off-by: AAJELLAL <[email protected]>
@AAJELLAL
Merge branch 'main' of https://github.com/gridsuite/gridstudy-app int…
75f849d 
…o ali/rewrite-service-in-typescript

# Conflicts:
#	src/components/dialogs/parameters/sensi/utils.ts
#	src/services/network-modification-types.ts
#	src/services/study/index.ts
#	src/services/study/network-modifications.ts
#	src/services/study/network.ts
@AAJELLAL
Resolve conflict.
e0d76e2 
Signed-off-by: AAJELLAL <[email protected]>
@AAJELLAL
resolve conflict and fix some review remarks
bf9a3c8 
Signed-off-by: AAJELLAL <[email protected]>
@AAJELLAL
Merge branch 'main' of https://github.com/gridsuite/gridstudy-app int…
b4578d3 
…o ali/rewrite-service-in-typescript
jamal-khey
jamal-khey reviewed Dec 18, 2024
View reviewed changes
Copy link
Contributor

@jamal-khey jamal-khey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

jamal-khey
jamal-khey approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@jamal-khey jamal-khey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

things can be improved but it's okey to merge it as it is . so we avoid future conflicts.
Test Ok

souissimai
souissimai approved these changes Dec 24, 2024
View reviewed changes
Copy link
Contributor

@souissimai souissimai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested

@AAJELLAL
Merge branch 'main' of https://github.com/gridsuite/gridstudy-app int…
3f18ad6 
…o ali/rewrite-service-in-typescript

# Conflicts:
#	src/components/diagrams/diagram-pane.tsx
#	src/components/diagrams/singleLineDiagram/position-diagram-pane.tsx
@AAJELLAL
resolve conflict
31e5ba5 
Signed-off-by: AAJELLAL <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
2.0% Coverage on New Code
1.0% Duplication on New Code

See analysis details on SonarQube Cloud

@AAJELLAL AAJELLAL merged commit 7d0530a into main Dec 26, 2024
5 checks passed
@AAJELLAL AAJELLAL deleted the ali/rewrite-service-in-typescript branch December 26, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tristan-WorkGH Tristan-WorkGH Tristan-WorkGH left review comments

@souissimai souissimai souissimai approved these changes

@jamal-khey jamal-khey jamal-khey approved these changes

@YenguiSeddik YenguiSeddik Awaiting requested review from YenguiSeddik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AAJELLAL @jamal-khey @souissimai @Tristan-WorkGH