Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Announcements #2036

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Announcements #2036

wants to merge 7 commits into from

Conversation

flomillot
Copy link
Contributor

@flomillot flomillot commented Mar 28, 2024

Add the possibility to see announcements from admins.
Use the hook created in commons-ui gridsuite/commons-ui#405
From #1902

Comment on lines +34 to +35
const webSocketBaseUrl = getWsBase();
return webSocketBaseUrl + PREFIX_CONFIG_NOTIFICATION_WS + '/global';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be inlined

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know I just kept the same style as above

const webSocketBaseUrl = getWsBase();
const webSocketUrl =
webSocketBaseUrl +
PREFIX_CONFIG_NOTIFICATION_WS +
'/notify?appName=' +
APP_NAME;

@thangqp thangqp closed this Jul 24, 2024
@thangqp thangqp deleted the announcements branch July 24, 2024 16:25
@thangqp thangqp restored the announcements branch July 24, 2024 17:42
@thangqp thangqp reopened this Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants