Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add jquery-ui.js minimal need #1064

Merged
merged 1 commit into from
Nov 21, 2019
Merged

add jquery-ui.js minimal need #1064

merged 1 commit into from
Nov 21, 2019

Conversation

adumesny
Copy link
Member

@adumesny adumesny commented Nov 21, 2019

Description

  • minimal subset we need (55k vs 248k), which is now part of gridstack.all.js
  • just 1 include needed now in demos
  • CDN use gridstack@latest

had to manually build download.jqueryui.com as the https://jqueryui.com/download/ custom downloader is no longer working as for >2 months ago. Looks like ship is gone..
see jquery/download.jqueryui.com#359

Checklist

  • Created tests which fail without the change (if possible)
  • All tests passing (yarn test)
  • Extended the README / documentation, if necessary

* minimal subset we need (55k vs 248k), which is now part of `gridstack.all.js`
* just 1 include needed now in demos
* CDN use gridstack@latest

had to manually build download.jqueryui.com as the https://jqueryui.com/download/
is no longer working as for >2 months ago. Looks like ship is gone..
see jquery/download.jqueryui.com#359
@coveralls
Copy link

Coverage Status

Coverage remained the same at 66.758% when pulling 0a51f87 on adumesny:develop into 7ab2f3c on gridstack:develop.

@adumesny adumesny merged commit e91ce7e into gridstack:develop Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants