-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GSYE-818: Use default CDS from gsy-web for testimg the CDS parser #562
Conversation
… correct CDS file
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #562 +/- ##
==========================================
- Coverage 67.25% 67.18% -0.08%
==========================================
Files 81 82 +1
Lines 5293 5312 +19
Branches 878 879 +1
==========================================
+ Hits 3560 3569 +9
- Misses 1575 1583 +8
- Partials 158 160 +2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the patience during the tedious try / fail / retry efforts that this PR probably needed (I reviewed per-commit and I saw the small changes needed on each step)
Reason for the proposed changes
Please describe what we want to achieve and why.
Proposed changes
GSY_WEB_BRANCH=feature/GSYE-818