Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSYE-818: Use default CDS from gsy-web for testimg the CDS parser #562

Merged
merged 9 commits into from
Dec 18, 2024

Conversation

hannesdiedrich
Copy link
Member

@hannesdiedrich hannesdiedrich commented Dec 18, 2024

Reason for the proposed changes

Please describe what we want to achieve and why.

Proposed changes

GSY_WEB_BRANCH=feature/GSYE-818

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 84.21053% with 3 lines in your changes missing coverage. Please review.

Project coverage is 67.18%. Comparing base (234ac1e) to head (43d575a).
Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #562      +/-   ##
==========================================
- Coverage   67.25%   67.18%   -0.08%     
==========================================
  Files          81       82       +1     
  Lines        5293     5312      +19     
  Branches      878      879       +1     
==========================================
+ Hits         3560     3569       +9     
- Misses       1575     1583       +8     
- Partials      158      160       +2     

Copy link
Contributor

@BigTava BigTava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

Copy link
Member

@spyrostz spyrostz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the patience during the tedious try / fail / retry efforts that this PR probably needed (I reviewed per-commit and I saw the small changes needed on each step)

@hannesdiedrich hannesdiedrich merged commit 5d32ab3 into master Dec 18, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants