FE-550-2: create _default_grid_root method in CommunityDataSheetParser #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #561 +/- ##
==========================================
+ Coverage 67.28% 67.30% +0.01%
==========================================
Files 81 81
Lines 5294 5297 +3
Branches 879 879
==========================================
+ Hits 3562 3565 +3
Misses 1573 1573
Partials 159 159 |
| @@ -141,11 +135,21 @@ def _create_grid(self) -> Dict: | |||
| "allow_external_connection": False, | |||
| "uuid": str(uuid.uuid4()), | |||
| "type": "Area", | |||
| "children": grid, | |||
| "children": None if children is None else children, | |||
There was a problem hiding this comment.
I think you missed the case when the user uploads a CDS in which case the _create_grid method should be called here.
Additionally, the "children" member should never be None. We hat lot's of issues in the past with that. I think we fixed them all, but better be save than sorry and add an empty list here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.