Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSYE-696: Added ScmStorage and ScmHeatPump to the launch simulation A… #507

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

spyrostz
Copy link
Member

…VRO schema.

@spyrostz spyrostz requested a review from a team February 28, 2024 16:13
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.44%. Comparing base (b542d19) to head (84e393d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #507   +/-   ##
=======================================
  Coverage   66.44%   66.44%           
=======================================
  Files          81       81           
  Lines        5272     5272           
  Branches      861      861           
=======================================
  Hits         3503     3503           
  Misses       1607     1607           
  Partials      162      162           

Copy link
Member

@hannesdiedrich hannesdiedrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spyrostz spyrostz merged commit 3b19feb into master Feb 29, 2024
4 checks passed
@spyrostz spyrostz deleted the bug/GSYE-696 branch February 29, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants