Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/gsye 682 #503

Merged
merged 9 commits into from
Feb 22, 2024
Merged

Feature/gsye 682 #503

merged 9 commits into from
Feb 22, 2024

Conversation

spyrostz
Copy link
Member

@spyrostz spyrostz commented Feb 1, 2024

No description provided.

…r backwards compatibility. Added new optional group_settings parameter.
…AVRO schema in order to allow starting simulations with the new SCM parameter set.
…ma, in order to support null values for intracommunity_rate_base_eur.
@spyrostz spyrostz requested a review from a team February 1, 2024 16:53
hannesdiedrich
hannesdiedrich previously approved these changes Feb 2, 2024
Copy link
Member

@hannesdiedrich hannesdiedrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -25,6 +25,7 @@ class CoefficientAlgorithm(Enum):
STATIC = 1
DYNAMIC = 2
NO_COMMUNITY_SELF_CONSUMPTION = 3
LIVE_STREAM = 4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be implemented in the frame of GSYE-672, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly. This is just a placeholder for the following ticket

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7032b36) 66.43% compared to head (4c21e5a) 66.44%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #503      +/-   ##
==========================================
+ Coverage   66.43%   66.44%   +0.01%     
==========================================
  Files          81       81              
  Lines        5270     5272       +2     
  Branches      861      861              
==========================================
+ Hits         3501     3503       +2     
  Misses       1607     1607              
  Partials      162      162              

@spyrostz spyrostz merged commit b542d19 into master Feb 22, 2024
4 checks passed
@spyrostz spyrostz deleted the feature/GSYE-682 branch February 22, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants