-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/gsye 682 #503
Feature/gsye 682 #503
Conversation
…r backwards compatibility. Added new optional group_settings parameter.
…AVRO schema in order to allow starting simulations with the new SCM parameter set.
…ma, in order to support null values for intracommunity_rate_base_eur.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -25,6 +25,7 @@ class CoefficientAlgorithm(Enum): | |||
STATIC = 1 | |||
DYNAMIC = 2 | |||
NO_COMMUNITY_SELF_CONSUMPTION = 3 | |||
LIVE_STREAM = 4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be implemented in the frame of GSYE-672, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly. This is just a placeholder for the following ticket
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #503 +/- ##
==========================================
+ Coverage 66.43% 66.44% +0.01%
==========================================
Files 81 81
Lines 5270 5272 +2
Branches 861 861
==========================================
+ Hits 3501 3503 +2
Misses 1607 1607
Partials 162 162 |
No description provided.