Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/gsye 663 #487

Merged
merged 4 commits into from
Dec 14, 2023
Merged

Feature/gsye 663 #487

merged 4 commits into from
Dec 14, 2023

Conversation

spyrostz
Copy link
Member

No description provided.

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Merging #487 (8019501) into master (2490130) will increase coverage by 0.00%.
Report is 1 commits behind head on master.
The diff coverage is 75.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #487   +/-   ##
=======================================
  Coverage   66.48%   66.48%           
=======================================
  Files          78       78           
  Lines        5150     5153    +3     
  Branches      852      852           
=======================================
+ Hits         3424     3426    +2     
- Misses       1565     1566    +1     
  Partials      161      161           

hannesdiedrich
hannesdiedrich previously approved these changes Nov 29, 2023
Copy link
Member

@hannesdiedrich hannesdiedrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

spyrostz and others added 2 commits December 13, 2023 09:03
… module level, since this being part of the class prevented correct serialization.
@spyrostz spyrostz merged commit 7d1c3d1 into master Dec 14, 2023
4 checks passed
@spyrostz spyrostz deleted the feature/GSYE-663 branch December 14, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants