Feature/gsye 650 fix #486
Feature/gsye 650 fix #486
Conversation
…cy and self-consumption calculation.
…atpump and Virtual Heatpump strategies. Added total_traded_energy_kWh to the AVRO schema.
| self._accumulate_total_energy_demanded(area_dict, core_stats) | ||
| self._accumulate_energy_trace(core_stats) | ||
| self._accumulate_energy_trace(core_stats, "P2P" in area_dict["name"]) |
There was a problem hiding this comment.
Do we really want to add this solution permanently?
If yes, we should add a more unique string IMO.
e.g. ##P2P## What do you think?
There was a problem hiding this comment.
Let me think of it a bit more and adapt it. Same goes for the "DH" string for distinguishing district heating.
gsy_framework/sim_results/kpi.py
Outdated
| for child in area_dict["children"]: | ||
| if is_producer_node_type(child): | ||
| if is_producer_node_type(child) or is_heatpump_node_type(child): |
There was a problem hiding this comment.
why is the heat pump also a producer?
There was a problem hiding this comment.
Should not be and good catch, thanks!
|
@spyrostz We should also discuss whether the distinguishing between P2P and DH should end up in our codebase (whether we should push this) |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #486 +/- ##
==========================================
- Coverage 66.48% 66.36% -0.12%
==========================================
Files 78 78
Lines 5150 5159 +9
Branches 852 857 +5
==========================================
Hits 3424 3424
- Misses 1565 1570 +5
- Partials 161 165 +4 |
No description provided.