Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix on_market_slot event #231

Merged
merged 2 commits into from
Jul 22, 2022
Merged

Fix on_market_slot event #231

merged 2 commits into from
Jul 22, 2022

Conversation

fievelk
Copy link
Contributor

@fievelk fievelk commented Jul 21, 2022

Reason for the proposed changes

The market event is currently not being used to trigger the on_market_slot (nor the old on_market_cycle) method when Redis is running.

Proposed changes

  • Call the new on_market_slot method when the market event is received.
  • Call on_market_cycle (old alias for the new on_market_slot) when on_market_slot is called.

References

INTEGRATION_TESTS_BRANCH=master

GSY_E_TARGET_BRANCH=master

GSY_FRAMEWORK_BRANCH=master

@fievelk fievelk requested a review from a team July 21, 2022 13:01
@fievelk fievelk changed the title Fix on market slot event Fix on_market_slot event Jul 21, 2022
@fievelk fievelk mentioned this pull request Jul 21, 2022
Open
mrsaemir
mrsaemir approved these changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@mrsaemir mrsaemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks.

spyrostz
spyrostz approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@spyrostz spyrostz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fievelk fievelk merged commit e27cb68 into master Jul 22, 2022
@fievelk fievelk deleted the fix-on-market-slot-event branch July 22, 2022 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spyrostz spyrostz spyrostz approved these changes

@mrsaemir mrsaemir mrsaemir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fievelk @mrsaemir @spyrostz