feature/fix-linter-issues #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alidaw
force-pushed
the
feature/fix-linter-issues
branch
from
2a12321 to
d05963e
Compare
alidaw
force-pushed
the
feature/fix-linter-issues
branch
from
d05963e to
3f9ec51
Compare
|
Rebased to be ahead of |
nvthongswansea
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementations out for review are used to get rid of style complaints detected by staticcheck linter.
Mostly following recurring issues have been solved:
error strings should not end with punctuation or newlines (ST1005)go-staticcheckerror strings should not be capitalized (ST1005)go-staticcheckshould omit nil check; len() for []github.com/gridscale/gsclient-go/v3.Credential is defined as zero (S1009)go-staticcheck