Commit for issue#39 #83
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the server-side validation. If a client is new joinee,he can create a new chatroom by sending NEW command or validate by CHKUSR command. The chatroom are generated at a single point,hence the disperancy coming in earlier case is resolved.
|
fix for issue #39. |
gridhead
requested changes
Oct 23, 2020
| @@ -9,6 +9,7 @@ | |||
|
|
|||
| sess = PromptSession() | |||
| sepr = chr(969696) | |||
| websocket = None | |||
There was a problem hiding this comment.
Please avoid such cross-type object initialization as far as possible.
| @@ -29,7 +30,7 @@ def decrjson(self, data): | |||
| return self.suit.decrypt(data.encode("utf8")).decode("utf8") | |||
|
|
|||
|
|
|||
| async def consumer_handler(cphrsuit, websocket, username, chatroom, servaddr): | |||
| async def consumer_handler(cphrsuit, username, chatroom, servaddr): | |||
There was a problem hiding this comment.
The websocket object must be passed here as a parameter.
| @@ -46,7 +47,7 @@ async def consumer_handler(cphrsuit, websocket, username, chatroom, servaddr): | |||
| pass | |||
|
|
|||
|
|
|||
| async def producer_handler(cphrsuit, websocket, username, chatroom, servaddr): | |||
| async def producer_handler(cphrsuit, username, chatroom, servaddr): | |||
There was a problem hiding this comment.
The websocket object must be passed here as a parameter.
|
Hi, I have added my justification for using this way, there. Please look that and reply what I should do? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the server-side validation.
If a client is new joinee,he can create a new chatroom by sending NEW command
or validate by CHKUSR command. The chatroom are generated at a single point,hence
the disperancy coming in earlier case is resolved.