Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update CI for linter and actions version #2606

Merged
merged 6 commits into from
Nov 25, 2022
Merged

build: update CI for linter and actions version #2606

merged 6 commits into from
Nov 25, 2022

Conversation

jamescowens
Copy link
Member

@jamescowens jamescowens commented Nov 25, 2022 •
edited
Loading

The CI environment no longer has Python 3.6. Update to use 3.9. Also update clang-format to 14, codespell to 2.2.2, and also update actions version in ci.yml to v3.

Note that BitCoin core has removed clang-format altogether from the linter, so @div72 or @barton2526 will put up a PR in the future to remove it here too.

@jamescowens jamescowens requested a review from div72 November 25, 2022 07:00
@jamescowens jamescowens self-assigned this Nov 25, 2022
@jamescowens jamescowens added this to the LaVerne milestone Nov 25, 2022
@jamescowens jamescowens changed the title build: Update python for linter to use 3.10.8 build: update CI for linter Nov 25, 2022
@jamescowens
Copy link
Member Author

jamescowens commented Nov 25, 2022 •
edited
Loading

@barton2526 Using 3.10 didn't work...

0s
Run actions/setup-python@v2
with:
python-version: 3.1
token: ***
env:
EVENT_TYPE: pull_request
COMMIT_COUNT:
CI_REPO_SLUG: gridcoin-community/Gridcoin-Research
Version 3.1 was not found in the local cache
Error: Version 3.1 with arch x64 not found
The list of all available versions can be found here: https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json

There must be a bug in the ci.yml parser. I don't really feel motivated to try and find it... :)

@jamescowens jamescowens force-pushed the update_ci branch 2 times, most recently from ec4636e to 6aef488 Compare November 25, 2022 19:27
@jamescowens jamescowens removed the request for review from div72 November 25, 2022 20:00
barton2526
barton2526 reviewed Nov 25, 2022
View reviewed changes
ci/lint/04_install.sh Outdated Show resolved Hide resolved
@jamescowens jamescowens changed the title build: update CI for linter build: update CI for linter and actions version Nov 25, 2022
@jamescowens
Copy link
Member Author

Just using Python 3.9 to get around the parsing problem - per @barton2526 EOL 2025.

@jamescowens jamescowens merged commit 48c82b4 into gridcoin-community:development Nov 25, 2022
jamescowens added a commit to jamescowens/Gridcoin-Research that referenced this pull request Nov 27, 2022
@jamescowens
5.4.1.0 2022-11-27, leisure
6a4285a 
Added
 - net: Add and document network messages in protocol.h (backport) gridcoin-community#2533 (@Pythonix)
 - Define MAX_DIGITS_BTC for magic number in BitcoinUnits::format gridcoin-community#2555 (@barton2526)
 - rpc: Implementation of getmrcinfo gridcoin-community#2570 (@jamescowens)
 - init: Add init error message if -printtoconsole and -daemon specified simultaneously gridcoin-community#2571 (@jamescowens)
 - rpc: getmrcinfo part 2 - add calculated minimum fees and fee boosting and by CPID reporting gridcoin-community#2575 (@jamescowens)
 - fs: fully initialize `_OVERLAPPED` for win32 gridcoin-community#2587 (@div72)
 - util: Diagnose Lib Version #1 gridcoin-community#2573 (@MinaFarhan)
 - util: Implement core diagnostics #2 (@jamescowens)
 - util: modify Win32LockedPageAllocator to query windows for limit. gridcoin-community#2536 (@div72)
 - gui, voting: Implement information for wallet holder's votes on poll info cards gridcoin-community#2605 (@jamescowens)

Changed
 - scripted-diff: Drop Darwin version for better maintainability gridcoin-community#2557 (@barton2526)
 - build: Require gcc8 on Ubuntu Bionic to enable C++17 features gridcoin-community#2579 (@barton2526)
 - util: Replace use of locale dependent atoi(…) with locale-independent std::from_chars(…) (C++17) gridcoin-community#2564 (@barton2526)
 - translation: Translation updates gridcoin-community#2581 (@jamescowens)
 - depends: update urls for dmg tools gridcoin-community#2583 (@div72)
 - Use ReadLE64 in uint256::GetUint64 instead of duplicating logic gridcoin-community#2586 (@div72)
 - util: Make Parse{Int,UInt}{32,64} use locale independent std::from_chars(…) (C++17) instead of locale dependent strto{l,ll,ul,ull} gridcoin-community#2592 (@barton2526)
 - build: don't set PORT=no in config.site gridcoin-community#2593 (@barton2526)
 - build: Replace `which` command with `command -v` gridcoin-community#2595 (@barton2526)
 - build: update ax_cxx_compile_stdcxx to serial 14 gridcoin-community#2596 (@barton2526)
 - gui: Changed the unlocked for staking only icons to green gridcoin-community#2598 (@delta1513)
 - gui: Translation updates gridcoin-community#2599 (@jamescowens)
 - build: update CI for linter and actions version gridcoin-community#2606 (@jamescowens)
 - gui: Update translations gridcoin-community#2608 (@jamescowens)

Removed
 - refactor: remove unused c-string variant of atoi64() gridcoin-community#2562 (@barton2526)
 - refactor: Remove unused CDataStream::rdbuf method gridcoin-community#2585 (@div72)

Fixed
 - net: Fix some benign races (backport) gridcoin-community#2532 (@Pythonix)
 - rpc: fix invalid parameter error codes for {sign,verify}message RPCs gridcoin-community#2556 (@barton2526)
 - build: Fix x86_64 <-> arm64 cross-compiling for macOS gridcoin-community#2560 (@barton2526)
 - rpc, mrc: Fix field name and initialization of mrc_fees_to_staker gridcoin-community#2567 (@jamescowens)
 - gui: Add missing resizeTableColumns to fix send address book column widths gridcoin-community#2569 (@jamescowens)
 - accrual: rebuild snapshot registry on corruption instead of crashing gridcoin-community#2577 (@div72)
 - doc: Fix link to MurmurHash3.cpp (moved from Google Code to Github) gridcoin-community#2584 (@div72)
 - fix help text for `revokebeacon` command gridcoin-community#2591 (@Pythonix)
 - util: Fix spelling error in gridcoinresearchd.cpp gridcoin-community#2590 (@jamescowens)
 - depends: always use correct ar for win qt build gridcoin-community#2588 (@div72)
 - util: Fix some bugs due to new implementation and change in BOINC dir handling (@jamescowens)
 - util: Diagnose lib - Implement changes to solve crash on some Boost 1.66 machines gridcoin-community#2597 (@jamescowens)
 - contrib: Check for `patch` command, Check for `wget` command gridcoin-community#2594 (@barton2526)
 - build: Check std::system for -[alert|block|wallet]notify gridcoin-community#2582 (@barton2526)
 - gui: Changed the wording on the tooltip for the address book gridcoin-community#2602 (@delta1513)
 - build: pass win32-dll to LT_INIT() gridcoin-community#2601 (@barton2526)
 - build: minor cleanups to native_clang package gridcoin-community#2600 (@barton2526)
 - util: restore translations to diagnostics gridcoin-community#2603 (@jamescowens)
 - refactor: Fix problems found by valgrind gridcoin-community#2607 (@jamescowens)
@barton2526 barton2526 mentioned this pull request Nov 30, 2022
Merged
@jamescowens jamescowens deleted the update_ci branch July 21, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barton2526 barton2526 barton2526 approved these changes

Assignees

@jamescowens jamescowens

Labels
build system compatibility
Projects
None yet
Milestone
LaVerne
Development

Successfully merging this pull request may close these issues.
2 participants
@jamescowens @barton2526