Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix convert from PSparseMatrix to PetscMatrix for MPI backend. #75

Merged
merged 1 commit into from
Feb 15, 2022

Conversation

fverdugo
Copy link
Member

No description provided.

@fverdugo
Copy link
Member Author

fverdugo commented Feb 14, 2022

This fix might be important to you @amartinhuertas.

Specially if you tried to assemble to SparseMatrixCSR{0,PetscScalar,PetscInt} to avoid copies.

The input of convert should be read-only, and we were modifying it here.

I haven't had forces to add a test (it's late here). Could you help with this?

@fverdugo fverdugo added the help wanted Extra attention is needed label Feb 14, 2022
@amartinhuertas
Copy link
Member

I haven't had forces to add a test (it's late here). Could you help with this?

Yes. I will add a test.

@fverdugo fverdugo merged commit aa6187f into master Feb 15, 2022
@fverdugo
Copy link
Member Author

@amartinhuertas I merge this since I need this fix asap. I'll open an issue about the missing test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants