Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimized MonomialBases evaluations #1059

Merged
merged 1 commit into from
Dec 1, 2024

Conversation

Antoinemarteau
Copy link
Contributor

And added associated benchmark in ./benchmark.

I obtain the following speedup ranges on functions called with VectorValue'd, TensorValue'd, SymTensorValue'd and SymTracelessTensorValue'd FE basis for spatial dimensions 1,2,3 and 5:

                              # 1D     2D     3D     5D     
  set_value_benchmark        # ~67%   85:95% 40:85% 30:80% 
  set_gradient_benchmark     #  0:3%  5:35%  8:55%  37:100%
  set_value_mc0_benchmark    #  0%    80:99% 0:90%  0:60%   
  set_gradient_mc0_benchmark # 16:18% 27:36% 22:60% 38:100%
  evaluate_1d_benchmark      # ~80%   ~84%   80:90% 90:95%
  gradient_1d_benchmark      # 10:17% 38:55% 50:75% 70:85%
  hessian_1d_benchmark       # ~6%    0:60%  40:80% 60:90%

added associated benchmark
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 70.42254% with 21 lines in your changes missing coverage. Please review.

Project coverage is 88.95%. Comparing base (440440d) to head (c4ab198).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
src/Polynomials/ModalC0Bases.jl 13.63% 19 Missing ⚠️
src/Polynomials/MonomialBases.jl 95.91% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1059      +/-   ##
==========================================
- Coverage   88.98%   88.95%   -0.04%     
==========================================
  Files         196      196              
  Lines       23777    23793      +16     
==========================================
+ Hits        21157    21164       +7     
- Misses       2620     2629       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JordiManyer JordiManyer merged commit 9009796 into gridap:master Dec 1, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants