Remove old debugging code #137
Conversation
| output_filename = 'ruc_results.json' | ||
| ruc_results.write(output_filename) | ||
|
|
||
| raise RuntimeError("Halting due to bug in pricing.") |
There was a problem hiding this comment.
Is this an actual error? Alternatively, should this at least log a warning?
There was a problem hiding this comment.
Maybe? Based on @xiangao1's experience it's hard to say.
This was originally some sanity-checking code I had added. But I think due to MIP tolerances (e.g., 0.99999 is "integer") the objective function after fixing the binaries can be arbitrarily far away from the objective function reported by the MIP solve. In theory, of course, the all of the price methods fix and/or relax binary variables from the MIP solve, which should result in a no-higher objective value.
In the end I thought just eliminating this code was best, because I think it gives too many false-positives. But I'm open to making this a warning.
There was a problem hiding this comment.
OK - I am all for removing the exception. I am torn if leaving in a warning would be useful.
This has occasionally become the source of trouble when using the day-ahead market model. The solver may report a higher objective due to numerical tolerance issues which are difficult to pin down precisely.