Shortcut simulator #113
Merged
Shortcut simulator #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darrylmelander
approved these changes
Aug 24, 2021
| 'zone': {'virtual_zone':{}}, | ||
| } | ||
| bus_id_to_names = defaultdict(lambda: 'virtual_bus') | ||
| parser._read_generators(data_directory, elements, bus_id_to_names) |
There was a problem hiding this comment.
A little dangerous to use a private method, but I can live with it. Maybe you can get the guy who wrote that function to document it though...
| yield InferrableForecastable(how_to_infer, gdata['p_min']['values']) | ||
| if isinstance(gdata['p_max'], dict): | ||
| yield InferrableForecastable(how_to_infer, gdata['p_max']['values']) | ||
| if 'p_cost' in gdata and isinstance(gdata['p_cost'], dict): |
There was a problem hiding this comment.
Just marking this as a spot to talk about tomorrow.
prescient/simulator/time_manager.py
Outdated
| # If the next plan won't be activated until after the simulation has finished, | ||
| # don't bother generating the plan. Push the next planning time out past the end. | ||
| # We need this check here in case a single day is simulated | ||
| if next_planning_time + timedelta(hours=self._ruc_delay) >= stop_time: |
There was a problem hiding this comment.
I'd prefer to adjust the logic below instead of duplicating the logic here
|
Now that I've gone down the route of include the virtual generators in the stack, we should probably also add an output file called |
* Add support for virtual generators in simulation, statistics, and output * New input format for shortcut simulations * Utility to convert prices in Prescient output to shortcut input * New shortcut simulation test
darrylmelander
force-pushed
the
shortcut_simulator
branch
from
67dde77 to
e975e78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #108 -- creates a "shortcut simulator" which just uses generator data and day-ahead/real-time LMPs. Fixes a few bugs with non-hourly SCEDs.