add after simulation callbacks #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bknueven
approved these changes
Aug 18, 2021
There was a problem hiding this comment.
I opted to rename it "finalization" as that's the opposite of "initialization", and added it to the test_plugin. I'll merge this when the tests pass.
@xiangao1 take a look at #107 -- it changes the plugin system slightly, but for the better. The new python API should also be easier to interact with.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @bknueven, would you mind looking at this PR? This PR add a plugin point after Prescient's simulation is over. This will provide plugin objects, e.g., bidder and tracker, opportunities to write their simulation results on the disk after the simulation is done. I would really appreciate your feedback! Thanks!