-
Notifications
You must be signed in to change notification settings - Fork 13
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Split tests into scheduled and triggered, to avoid disabling PR tests.
Github disables workflows with a cron schedule if the repo goes too long without any changes. It appears to disable all triggers, not just the schedule trigger. As a result, PRs never get tested and sit there in limbo forever. This is a) a test to see if that is really what is causing our PR tests to never run, and b) a fix for the issue. The fix is to split testing into two separate actions, one for scheduled tests and one for all other tests. Both call the run-tests workflow.
- Loading branch information
1 parent
31ac9f5
commit ef95e18
Showing
3 changed files
with
31 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
name: Test Changes | ||
|
||
on: | ||
# Trigger the workflow on push or pull request, | ||
# but only for the main branch | ||
push: | ||
branches: | ||
- main | ||
pull_request: | ||
branches: | ||
- main | ||
# Allow it to be manually triggered as well | ||
workflow_dispatch: | ||
|
||
jobs: | ||
call-run-tests: | ||
uses: ./.github/workflows/run-tests.yml | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
name: Weekly Tests | ||
|
||
on: | ||
schedule: | ||
- cron: 58 7 * * 0 | ||
|
||
jobs: | ||
call-run-tests: | ||
uses: ./.github/workflows/run-tests.yml | ||
|