Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more robust handling of voltage angle difference limits #267

Merged
merged 1 commit into from
Feb 16, 2022

Conversation

michaelbynum
Copy link
Collaborator

Summary/Motivation:

The computation of bounds for the auxiliary variables c = v_f * v_t * cos(dt) and s = vf * vt * sin(dt) had bugs. This PR uses interval arithmetic to improve the robustness of these computations and adds tests.

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

Copy link
Collaborator

@DLWoodruff DLWoodruff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense and it is now easier to read.

@michaelbynum michaelbynum merged commit a11fa61 into grid-parity-exchange:main Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants